[ 
https://issues.apache.org/jira/browse/YARN-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625630#comment-14625630
 ] 

Wangda Tan commented on YARN-2003:
----------------------------------

[~sunilg], 
Patch generally looks good, except one comment:

Currently checkApplicationPriority throws exception, I think we can make this 
capped by max-priority automatically. I tried to run {{renice}} command in 
linux, priority more than +20 will be capped to 20 and priority less than -20 
will be capped to -20.

So back to your patch, you don't need separated 
getDefaultApplicationPriorityFromQueue and checkApplicationPriority. Merge them 
to getApplicationPriority with parameter queue/user/priority/application-id and 
returns new Priority should be enough.

Thoughts?

> Support for Application priority : Changes in RM and Capacity Scheduler
> -----------------------------------------------------------------------
>
>                 Key: YARN-2003
>                 URL: https://issues.apache.org/jira/browse/YARN-2003
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-2003.patch, 00010-YARN-2003.patch, 
> 0002-YARN-2003.patch, 0003-YARN-2003.patch, 0004-YARN-2003.patch, 
> 0005-YARN-2003.patch, 0006-YARN-2003.patch, 0007-YARN-2003.patch, 
> 0008-YARN-2003.patch, 0009-YARN-2003.patch, 0011-YARN-2003.patch, 
> 0012-YARN-2003.patch, 0013-YARN-2003.patch, 0014-YARN-2003.patch, 
> 0015-YARN-2003.patch, 0016-YARN-2003.patch, 0017-YARN-2003.patch, 
> 0018-YARN-2003.patch, 0019-YARN-2003.patch, 0020-YARN-2003.patch
>
>
> AppAttemptAddedSchedulerEvent should be able to receive the Job Priority from 
> Submission Context and store.
> Later this can be used by Scheduler.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to