[
https://issues.apache.org/jira/browse/YARN-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627080#comment-14627080
]
Sangjin Lee commented on YARN-3049:
-----------------------------------
Thanks [~zjshen] for your WIP patch! I skimmed through it, and I generally
agree with the approach you're taking in this patch.
Some early comments and thoughts:
- Later we could work on the filtering code to make it more expressive, etc. I
see you have defined a number of {{match*()}} methods, and that's a good start
in that direction.
- {{lookupFlowContext()}}: I suspect we might want to cache the flow context
for better performance. Ideally it would need to be limited by size (LRU).
- Maybe a nit, but instead of setting something and clearing it later on if it
is not supposed to be retrieved, how about setting it only if it is supposed to
be retrieved? I'm talking about code that fetches contents such as relatesTo,
info, config, events, ...
- {{getEntities()}}: just break instead of pollLast()?
- {{readMetrics()}}: SINGLE_VALUE v. TIME_SERIES?
> [Storage Implementation] Implement storage reader interface to fetch raw data
> from HBase backend
> ------------------------------------------------------------------------------------------------
>
> Key: YARN-3049
> URL: https://issues.apache.org/jira/browse/YARN-3049
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Sangjin Lee
> Assignee: Zhijie Shen
> Attachments: YARN-3049-WIP.1.patch
>
>
> Implement existing ATS queries with the new ATS reader design.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
