Rohith Sharma K S commented on YARN-3535:

bq. wouldn't removing the if clause just solve this ?
Yes, Just removing if clause should sovle the this issue problem. But problem 
is with legacy behaviour i.e if RM/NM work preserving restart feature is NOT 
enabled, then on NM restart, running containers should be killed which is 
currently achieved by if-clause. So retaining the existing behaviour, this 
issue fix is required. And the YARN-3286 is tracking jira for Reconnected event 
clean up change as you have mentioned.

>  ResourceRequest should be restored back to scheduler when RMContainer is 
> killed at ALLOCATED
> ---------------------------------------------------------------------------------------------
>                 Key: YARN-3535
>                 URL: https://issues.apache.org/jira/browse/YARN-3535
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Peng Zhang
>            Assignee: Peng Zhang
>            Priority: Critical
>         Attachments: 0003-YARN-3535.patch, YARN-3535-001.patch, 
> YARN-3535-002.patch, syslog.tgz, yarn-app.log
> During rolling update of NM, AM start of container on NM failed. 
> And then job hang there.
> Attach AM logs.

This message was sent by Atlassian JIRA

Reply via email to