[ 
https://issues.apache.org/jira/browse/YARN-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14630042#comment-14630042
 ] 

Wangda Tan commented on YARN-2003:
----------------------------------

Thanks [~sunilg] to update, few more comments regarding the latest patch:
- I suggest defer the consideration of queue checking. Currently we're changing 
how to do queue mapping. Ideally, it should be done before submit to scheduler 
(maybe before assigning application priority), see YARN-3635.
- Assumption of queue will be existed before submit to scheduler may be not 
always valid. With queue mapping, scheduler can create queue when accepting 
application. I suggest remove the check of queue's existence. Instead, you can 
have a private method to get priority by queue name. If queue is not existed, 
you can assign default priority to application.
- Comparison of priority should use Priority.compareTo instead of ">/<".

> Support for Application priority : Changes in RM and Capacity Scheduler
> -----------------------------------------------------------------------
>
>                 Key: YARN-2003
>                 URL: https://issues.apache.org/jira/browse/YARN-2003
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-2003.patch, 00010-YARN-2003.patch, 
> 0002-YARN-2003.patch, 0003-YARN-2003.patch, 0004-YARN-2003.patch, 
> 0005-YARN-2003.patch, 0006-YARN-2003.patch, 0007-YARN-2003.patch, 
> 0008-YARN-2003.patch, 0009-YARN-2003.patch, 0011-YARN-2003.patch, 
> 0012-YARN-2003.patch, 0013-YARN-2003.patch, 0014-YARN-2003.patch, 
> 0015-YARN-2003.patch, 0016-YARN-2003.patch, 0017-YARN-2003.patch, 
> 0018-YARN-2003.patch, 0019-YARN-2003.patch, 0020-YARN-2003.patch, 
> 0021-YARN-2003.patch, 0022-YARN-2003.patch
>
>
> AppAttemptAddedSchedulerEvent should be able to receive the Job Priority from 
> Submission Context and store.
> Later this can be used by Scheduler.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to