Joep Rottinghuis commented on YARN-3908:

Patch looks good with one comment. I completely overlooked the event info map, 
because it isn't part of the javadoc on the EntityTable. I should have 
double-checked but didn't. Thanks for catching this.

[~sjlee0] I think it would be good to update the javadoc that describes the 
EntityTable in the EntityTable.java file.
The same is probably missing from the doc "Timeline service schema for native 
HBase tables" (not sure which jira the PDF for that doc is attached to), 
because I copied it from the code. I don't think that the application table has 
been copied yet, so it won't be missing from there. 

> Bugs in HBaseTimelineWriterImpl
> -------------------------------
>                 Key: YARN-3908
>                 URL: https://issues.apache.org/jira/browse/YARN-3908
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Vrushali C
>         Attachments: YARN-3908-YARN-2928.001.patch, 
> YARN-3908-YARN-2928.002.patch, YARN-3908-YARN-2928.003.patch
> 1. In HBaseTimelineWriterImpl, the info column family contains the basic 
> fields of a timeline entity plus events. However, entity#info map is not 
> stored at all.
> 2 event#timestamp is also not persisted.

This message was sent by Atlassian JIRA

Reply via email to