Naganarasimha G R updated YARN-3045:
    Attachment: YARN-3045-YARN-2928.006.patch

Hi [~djp] & [~varun_saxena] ,
  I have addressed the comments except for these :
bq. why we hook the track of container start event in ContainerManagerImpl, but 
for container finished event, we do it inside of ContainerImpl?
As explained earlier on recovery it will send multiple events out hence have 
done it in that way

bq. Indentation between switch and case.
bq. A cosmetic comment. Some of the lines are too long (> 80 chars).
Well, as per the guidelines(HowToContribute Wiki) we need to use the Sun's 
conventions except for the 2 space indent and 4. so i again rechecked the 
modifications using the eclipse's formatter and it gave the same, if req can do 
the modifications for the switch case. pls suggest 

bq. Will a single event queue with a single event handling thread in async 
dispatcher be enough to handle container events ? I think they may be too many.
As its per single NM (not @ cluster level) i think it should be fine. If req we 
can add Multi dispatcher later on. thoughts ?

for Priority should i create a new jira?

> [Event producers] Implement NM writing container lifecycle events to ATS
> ------------------------------------------------------------------------
>                 Key: YARN-3045
>                 URL: https://issues.apache.org/jira/browse/YARN-3045
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3045-YARN-2928.002.patch, 
> YARN-3045-YARN-2928.003.patch, YARN-3045-YARN-2928.004.patch, 
> YARN-3045-YARN-2928.005.patch, YARN-3045-YARN-2928.006.patch, 
> YARN-3045.20150420-1.patch
> Per design in YARN-2928, implement NM writing container lifecycle events and 
> container system metrics to ATS.

This message was sent by Atlassian JIRA

Reply via email to