Joep Rottinghuis commented on YARN-3908:

What does this mean for the HBaseTimelineWriterImpl?

Two TimelineEvents are equal only if the timestamp is equal AND the type is 
equal AND the entire info maps are equal.
What would we query by event type, timestamp and event info key? Do users 
always have to specify the timestamp?
Do we need to store only the latest event for each timestamp, or all of them?
The answer to all these questions are critical for the key design for the 
It would almost sound like the key should be type and timestamp, but what about 
the entire event info map?

> Bugs in HBaseTimelineWriterImpl
> -------------------------------
>                 Key: YARN-3908
>                 URL: https://issues.apache.org/jira/browse/YARN-3908
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Zhijie Shen
>            Assignee: Vrushali C
>         Attachments: YARN-3908-YARN-2928.001.patch, 
> YARN-3908-YARN-2928.002.patch, YARN-3908-YARN-2928.003.patch, 
> YARN-3908-YARN-2928.004.patch, YARN-3908-YARN-2928.004.patch, 
> YARN-3908-YARN-2928.005.patch
> 1. In HBaseTimelineWriterImpl, the info column family contains the basic 
> fields of a timeline entity plus events. However, entity#info map is not 
> stored at all.
> 2 event#timestamp is also not persisted.

This message was sent by Atlassian JIRA

Reply via email to