[
https://issues.apache.org/jira/browse/YARN-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638206#comment-14638206
]
Sunil G commented on YARN-3963:
-------------------------------
Hi [~bibinchundatt]
Thanks for reporting this.
I feel it is better to throw back an error from NodeLabelManager when a
duplication occurs. Because if we are trying to overwrite the exclusivity of a
label, we may need few more tuning in scheduler side.
Thoughts?
> AddNodeLabel on duplicate label addition shows success
> -------------------------------------------------------
>
> Key: YARN-3963
> URL: https://issues.apache.org/jira/browse/YARN-3963
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Bibin A Chundatt
> Assignee: Bibin A Chundatt
> Priority: Minor
>
> Currently as per the code in
> {{CommonNodeLabelManager#addToClusterNodeLabels}} when we add same nodelabel
> again event will not be fired so no updation is done.
>
> {noformat}
> ./yarn rmadmin –addToClusterNodeLabels x
> ./yarn rmadmin –addToClusterNodeLabels “x(exclusive=true)”
> ./yarn rmadmin –addToClusterNodeLabels “x(exclusive=false)”
> {noformat}
> All these commands will give success when applied through CLI again
>
> {code}
> 2015-07-22 21:16:57,779 INFO
> org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager: Add labels:
> [<z:exclusivity=true>]
> 2015-07-22 21:16:57,779 INFO
> org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger: USER=dsperf
> IP=10.19.92.117 OPERATION=addToClusterNodeLabels TARGET=AdminService
> RESULT=SUCCESS
> 2015-07-22 21:17:06,431 INFO
> org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager: Add labels:
> [<z:exclusivity=false>]
> 2015-07-22 21:17:06,431 INFO
> org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger: USER=dsperf
> IP=<IP> OPERATION=addToClusterNodeLabels TARGET=AdminService
> RESULT=SUCCESS
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
