[ 
https://issues.apache.org/jira/browse/YARN-2545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14638610#comment-14638610
 ] 

Hong Zhiguo commented on YARN-2545:
-----------------------------------

RMAppEventType#ATTEMPT_FAILED is not suitable because it leads to check of 
"maxAppAttempt". 
Here AM unregistered with "getFinalApplicationStatus()==FAILED",  the RMApp 
should transit to "FAILED" without check of "maxAppAttempt"

In current implementation of RMAppImpl, targetedFinalState of 
FinalSavingTransition is statically determined by (preState, eventType). A 
simple solution is to replace ATTEMPT_UNREGISTERED event with 2 types of event: 
ATTEMPT_UNREGISTERED_SUCC and ATTEMPT_UNREGISTERED_FAIL.

Any suggestion?

> RMApp should transit to FAILED when AM calls finishApplicationMaster with 
> FAILED
> --------------------------------------------------------------------------------
>
>                 Key: YARN-2545
>                 URL: https://issues.apache.org/jira/browse/YARN-2545
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Hong Zhiguo
>            Assignee: Hong Zhiguo
>            Priority: Minor
>
> If AM calls finishApplicationMaster with getFinalApplicationStatus()==FAILED, 
> and then exits, the corresponding RMApp and RMAppAttempt transit to state 
> FINISHED.
> I think this is wrong and confusing. On RM WebUI, this application is 
> displayed as "State=FINISHED, FinalStatus=FAILED", and is counted as "Apps 
> Completed", not as "Apps Failed".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to