[ 
https://issues.apache.org/jira/browse/YARN-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639517#comment-14639517
 ] 

Xuan Gong commented on YARN-3967:
---------------------------------

Thanks for working on this. [~mitdesai]. The patch looks good overall. Just one 
minor comment:
Could we create a common function for this
{code}
if (conf.getBoolean(YarnConfiguration.APPLICATION_HISTORY_ENABLED,      
YarnConfiguration.DEFAULT_APPLICATION_HISTORY_ENABLED)) {
    isAHSEnabled = true;
            }

            if (isAHSEnabled) {
              try {
                historyManager = getAHSProxy(conf);
              } catch (IOException e) {
                throw new YarnRuntimeException(e);
              }
            }
            else {
              this.historyManager = null;
{code}
Since this piece of code is used in multiple place ?


> Fetch the application report from the AHS if the RM does not know about it
> --------------------------------------------------------------------------
>
>                 Key: YARN-3967
>                 URL: https://issues.apache.org/jira/browse/YARN-3967
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.7.1
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>         Attachments: YARN-3967.1.patch, YARN-3967.2.patch
>
>
> If the application history service has been enabled and RM has forgotten 
> anout an application, try and fetch the app report form the AHS.
> On larger clusters, the RM can forget about the applications in about 30 
> minutes. The proxy url generated during the job submission will try to fetch 
> the app report from the RM and will fail to get anything from there. If the 
> app is not found in the RM, we will need to get the application report from 
> the Application History Server  (if it is enabled) to see if we can get any 
> information on that application before throwing an exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to