[ 
https://issues.apache.org/jira/browse/YARN-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639983#comment-14639983
 ] 

Akira AJISAKA commented on YARN-3958:
-------------------------------------

Thanks [~varun_saxena] for updating the patch. Would you replace tabs with 
whitespaces in TestYarnConfigurationFields.java?
{code}
+    configurationPropsToSkipCompare
+        .add(YarnConfiguration
+           .YARN_SECURITY_SERVICE_AUTHORIZATION_APPLICATIONCLIENT_PROTOCOL);
+    configurationPropsToSkipCompare
+        .add(YarnConfiguration
+           .YARN_SECURITY_SERVICE_AUTHORIZATION_APPLICATIONMASTER_PROTOCOL);
{code}
The code has tabs before {{.YARN_SECURITY_...}}. I'm +1 if that is addressed.

> TestYarnConfigurationFields should be moved to hadoop-yarn-api
> --------------------------------------------------------------
>
>                 Key: YARN-3958
>                 URL: https://issues.apache.org/jira/browse/YARN-3958
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: YARN-3958.01.patch, YARN-3958.02.patch
>
>
> Currently TestYarnConfigurationFields is present in hadoop-yarn-common. The 
> test is for checking whether all the configurations declared in 
> YarnConfiguration exist in yarn-default.xml or not.
> But as YarnConfiguration is in hadoop-yarn-api, if somebody changes this 
> file, it is not necessary that this test will be run. So if the developer 
> misses to update yarn-default.xml and patch is committed, it will lead to 
> unnecessary test failures after commit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to