Rohith Sharma K S commented on YARN-3948:

Thanks [~sunilg] for working on this.
Some comments and doubts.
# Since it is change in applicationReport , it would required to modify in all 
the client interfaces such as ApplicationCLI/REST/timeline/webUI.  Do you have 
plan for doing these separatly OR in single jira. Any thoughts?
# I think change in BuilderUtils would create compatible issue if any 
client(TEZ) is using eventhough class is marked as @private. So better to 
setPriority instead of adding new parameter. May be it can be cross checked 
once with other folks.
# Can you add test for fetching priority in {{TestRMWebServicesApps}}?
# The test verification for number of xml element may fail in 
{{TestRMWebServicesApps#verifyAppInfo}}. Total number should be 29 after this 

> Display Application Priority in RM Web UI
> -----------------------------------------
>                 Key: YARN-3948
>                 URL: https://issues.apache.org/jira/browse/YARN-3948
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: webapp
>    Affects Versions: 2.7.1
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-3948.patch, ApplicationPage.png, 
> ClusterPage.png
> Application Priority can be displayed in RM Web UI Application page.

This message was sent by Atlassian JIRA

Reply via email to