[ 
https://issues.apache.org/jira/browse/YARN-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642141#comment-14642141
 ] 

Karthik Kambatla commented on YARN-3534:
----------------------------------------

Thanks for updating the patch, [~elgoiri]. The latest patch looks pretty good. 
Few minor comments:
# Let us not deprecate {{NM_CONTAINER_MON_INTERVAL_MS}}. Deprecating the 
default value seems reasonable. One might want to specify a different interval 
for node monitoring and container monitoring. 
# Make corresponding changes to yarn-site.xml
# {{NodeResourceMonitorImpl#serviceStop}}: the log message should say couldn't 
wait for the thread to join, and may be we should log it as WARN instead of INFO
# ContainersMonitorImpl: Users could continue to use the deprecated configs. If 
those are specified and the new ones are not, we should fallback to the 
deprecated ones. If this becomes too complicated, I am comfortable with leaving 
the configs for container-monitoring as is. We could file a follow-up JIRA to 
clean these configs for Hadoop-3.x.

> Collect memory/cpu usage on the node
> ------------------------------------
>
>                 Key: YARN-3534
>                 URL: https://issues.apache.org/jira/browse/YARN-3534
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>    Affects Versions: 2.7.0
>            Reporter: Inigo Goiri
>            Assignee: Inigo Goiri
>         Attachments: YARN-3534-1.patch, YARN-3534-10.patch, 
> YARN-3534-11.patch, YARN-3534-12.patch, YARN-3534-14.patch, 
> YARN-3534-15.patch, YARN-3534-2.patch, YARN-3534-3.patch, YARN-3534-3.patch, 
> YARN-3534-4.patch, YARN-3534-5.patch, YARN-3534-6.patch, YARN-3534-7.patch, 
> YARN-3534-8.patch, YARN-3534-9.patch
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> YARN should be aware of the resource utilization of the nodes when scheduling 
> containers. For this, this task will implement the collection of memory/cpu 
> usage on the node.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to