[jira] [Commented] (YARN-1643) Make ContainersMonitor can support change monitoring size of an allocated container in NM side

[Jian He (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-1643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645319#comment-14645319
 ] 

Jian He commented on YARN-1643:
-------------------------------

Thanks [~mding] ! 
- Here, memory * 2^20, but it gets reverted later on at {{info.pmemLimit >> 
20}}, we can just use the original value ?
{code}
      this.pmemLimit = resource.getMemory() * 1024L * 1024L;
{code}
- Do you think we can change the trackingContainers to be concurrentHashMap and 
update the ptInfo directly ?  Also the getter and setter of ptInfo can 
synchronize on the ptInfo object
{code}
      synchronized (this.containersToBeChanged) {
        this.containersToBeChanged.add(new ContainerResourceToChange(
            containerId, changeEvent.getResource()));
      }
      // Trigger a round of containers check immediately
      enforceResourceLimits();
{code}

> Make ContainersMonitor can support change monitoring size of an allocated 
> container in NM side
> ----------------------------------------------------------------------------------------------
>
>                 Key: YARN-1643
>                 URL: https://issues.apache.org/jira/browse/YARN-1643
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Wangda Tan
>            Assignee: MENG DING
>         Attachments: YARN-1643-YARN-1197.4.patch, 
> YARN-1643-YARN-1197.5.patch, YARN-1643-YARN-1197.6.patch, YARN-1643.1.patch, 
> YARN-1643.2.patch, YARN-1643.3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)