[ 
https://issues.apache.org/jira/browse/YARN-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14646501#comment-14646501
 ] 

Hadoop QA commented on YARN-3919:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  20m  6s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear 
to include any new or modified tests.  Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch. |
| {color:green}+1{color} | javac |  10m 22s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |  12m 38s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 28s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   1m  5s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 44s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 42s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 56s | The patch does not introduce 
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests |   2m 12s | Tests passed in 
hadoop-yarn-common. |
| | |  51m 18s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12747812/0003-YARN-3919.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 5205a33 |
| hadoop-yarn-common test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/8706/artifact/patchprocess/testrun_hadoop-yarn-common.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/8706/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8706/console |


This message was automatically generated.

> NPEs' while stopping service after exception during 
> CommonNodeLabelsManager#start
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-3919
>                 URL: https://issues.apache.org/jira/browse/YARN-3919
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.7.0
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: 0003-YARN-3919.patch, YARN-3919.01.patch, 
> YARN-3919.02.patch
>
>
> We get NPE during CommonNodeLabelsManager#serviceStop and 
> AsyncDispatcher#serviceStop if ConnectException on call to 
> CommonNodeLabelsManager#serviceStart occurs.
> {noformat}
> 2015-07-10 19:39:37,825 WARN main-EventThread 
> org.apache.hadoop.service.AbstractService: When stopping the service 
> org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager : 
> java.lang.NullPointerException
> java.lang.NullPointerException
>         at 
> org.apache.hadoop.yarn.nodelabels.FileSystemNodeLabelsStore.close(FileSystemNodeLabelsStore.java:99)
>         at 
> org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager.serviceStop(CommonNodeLabelsManager.java:278)
>         at 
> org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
>         at 
> org.apache.hadoop.service.ServiceOperations.stop(ServiceOperations.java:52)
>         at 
> org.apache.hadoop.service.ServiceOperations.stopQuietly(ServiceOperations.java:80)
>         at 
> org.apache.hadoop.service.AbstractService.start(AbstractService.java:203)
>         at 
> org.apache.hadoop.service.CompositeService.serviceStart(CompositeService.java:120)
>         at 
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$RMActiveServices.serviceStart(ResourceManager.java:588)
>         at 
> org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
>         at 
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.startActiveServices(ResourceManager.java:998)
>         at 
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$1.run(ResourceManager.java:1039)
>         at 
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$1.run(ResourceManager.java:1035)
> {noformat}
> {noformat}
> java.lang.NullPointerException
>         at 
> org.apache.hadoop.yarn.event.AsyncDispatcher.serviceStop(AsyncDispatcher.java:142)
>         at 
> org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
>         at 
> org.apache.hadoop.service.ServiceOperations.stop(ServiceOperations.java:52)
>         at 
> org.apache.hadoop.service.ServiceOperations.stopQuietly(ServiceOperations.java:80)
>         at 
> org.apache.hadoop.service.CompositeService.stop(CompositeService.java:157)
>         at 
> org.apache.hadoop.service.CompositeService.serviceStop(CompositeService.java:131)
>         at 
> org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
>         at 
> org.apache.hadoop.service.ServiceOperations.stop(ServiceOperations.java:52)
>         at 
> org.apache.hadoop.service.ServiceOperations.stopQuietly(ServiceOperations.java:80)
> {noformat}
> These NPEs' fill up the logs. Although, this doesn't cause any functional 
> issue but its a nuisance and we ideally should have null checks in 
> serviceStop.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to