Li Lu commented on YARN-3906:

...fixing formatting problems...

bq. Hi Sangjin Lee, I looked at the patch, and have one general question. It 
appears that the application table reuses most of the data schema of the entity 
table, with just some slight changes on its row keys. I've also noticed that 
the newly added Application\*.java files overlap significantly with 
Entity\*.java. While the current patch is totally fine in its core functions, 
I'm wondering if it is possible to reuse most of the code from the entity 
table. Ideally, we may want to build our \*Table, \*ColumnFamily, etc. on each 
new data schema, rather than on each new table? IIUC, two most significant 
differences between the entity table and the application table are table names 
and row key structures. Maybe we can change the Entity classes to allow those 
differences? Or, am I missing any key points here?

> split the application table from the entity table
> -------------------------------------------------
>                 Key: YARN-3906
>                 URL: https://issues.apache.org/jira/browse/YARN-3906
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>         Attachments: YARN-3906-YARN-2928.001.patch, 
> YARN-3906-YARN-2928.002.patch
> Per discussions on YARN-3815, we need to split the application entities from 
> the main entity table into its own table (application).

This message was sent by Atlassian JIRA

Reply via email to