Arun Suresh commented on YARN-3736:

The patch looks mostly good [~adhoot],

Some minor comments :
# Should'nt we update the versionInfo from (1, 2) since we are actually 
modifying the state store API ?
# What would be the order of objects stored in the Reservation System root ? 
Should we not handle garbage collection of non active plans / reservations ? 
Think we should be careful of not running into situations like YARN-2962 .. 
which incidentally is not too much of an issue since we can actually limit to 
number of active/running applications.

> Add RMStateStore apis to store and load accepted reservations for failover
> --------------------------------------------------------------------------
>                 Key: YARN-3736
>                 URL: https://issues.apache.org/jira/browse/YARN-3736
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, fairscheduler, resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-3736.001.patch, YARN-3736.001.patch, 
> YARN-3736.002.patch, YARN-3736.003.patch
> We need to persist the current state of the plan, i.e. the accepted 
> ReservationAllocations & corresponding RLESpareseResourceAllocations  to the 
> RMStateStore so that we can recover them on RM failover. This involves making 
> all the reservation system data structures protobuf friendly.

This message was sent by Atlassian JIRA

Reply via email to