[ 
https://issues.apache.org/jira/browse/YARN-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649132#comment-14649132
 ] 

Hudson commented on YARN-3963:
------------------------------

SUCCESS: Integrated in Hadoop-Yarn-trunk #1003 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/1003/])
YARN-3963. AddNodeLabel on duplicate label addition shows success. (Bibin A 
Chundatt via wangda) (wangda: rev 8acb30b0167e498991aef6993df7e36020428844)
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/nodelabels/TestCommonNodeLabelsManager.java
* 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java
* hadoop-yarn-project/CHANGES.txt


> AddNodeLabel on duplicate label addition shows success 
> -------------------------------------------------------
>
>                 Key: YARN-3963
>                 URL: https://issues.apache.org/jira/browse/YARN-3963
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: 0001-YARN-3963.patch, 0002-YARN-3963.patch, 
> 0003-YARN-3963.patch, 0004-YARN-3963.patch
>
>
> Currently as per the code in 
> {{CommonNodeLabelManager#addToClusterNodeLabels}} when we add same nodelabel 
> again event will not be fired so no updation is done. 
>  
> {noformat}
> ./yarn rmadmin –addToClusterNodeLabels x
> ./yarn rmadmin –addToClusterNodeLabels “x(exclusive=true)”
> ./yarn rmadmin –addToClusterNodeLabels “x(exclusive=false)”
>  {noformat}
> All these commands will give success when applied again through CLI 
>  
> {code}
> 2015-07-22 21:16:57,779 INFO 
> org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager: Add labels: 
> [<z:exclusivity=true>]
> 2015-07-22 21:16:57,779 INFO 
> org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger: USER=dsperf   
> IP=10.19.92.117 OPERATION=addToClusterNodeLabels        TARGET=AdminService   
>   RESULT=SUCCESS
> 2015-07-22 21:17:06,431 INFO 
> org.apache.hadoop.yarn.nodelabels.CommonNodeLabelsManager: Add labels: 
> [<z:exclusivity=false>]
> 2015-07-22 21:17:06,431 INFO 
> org.apache.hadoop.yarn.server.resourcemanager.RMAuditLogger: USER=dsperf   
> IP=<IP> OPERATION=addToClusterNodeLabels        TARGET=AdminService     
> RESULT=SUCCESS
>  {code}
> Also since exclusive=true to false is not supported success is misleading



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to