Zhijie Shen commented on YARN-3049:

I uploaded a new patch to address Sangjin's comments except bellow:

bq. l.93: What does it mean to indicate newApp for a set of entities? What if 
the set of entities contains bunch of different applications?

I don't worry about this, because the the put request to the app collector is 
related to the same app.

bq. See comments above; rather than relying on the boolean flag in the 
arguments, can we detect the case of the application created event and do it?

See my comments above.

> [Storage Implementation] Implement storage reader interface to fetch raw data 
> from HBase backend
> ------------------------------------------------------------------------------------------------
>                 Key: YARN-3049
>                 URL: https://issues.apache.org/jira/browse/YARN-3049
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Zhijie Shen
>         Attachments: YARN-3049-WIP.1.patch, YARN-3049-WIP.2.patch, 
> YARN-3049-WIP.3.patch, YARN-3049-YARN-2928.2.patch, 
> YARN-3049-YARN-2928.3.patch, YARN-3049-YARN-2928.4.patch
> Implement existing ATS queries with the new ATS reader design.

This message was sent by Atlassian JIRA

Reply via email to