Naganarasimha G R commented on YARN-3045:

hi [~djp],
 Thanks for the feedback.
bq. Ok. Let's get basic things in first then discuss/work on other details 
later if that move work quickly.
Have uploaded a WIP patch, can you take a look at it 

bq. What's the concern to have NodeManagerEntity? Without this, how could we 
store something like NM's configuration?
Well here what Sangjin's & as well my thoughts are if are going to query NM 
level Application events as part of application then it should be under 
ApplicationEntity and if for other scenarios we req then we can have 
NodeManagerEntity, i think.

bq.  If collector has no add-on knowledge against client, it could be simpler 
to pass down sync/async() from client to sync/async in writer.
Did you mean by {{sync/async in writer}} as {{putEntities & Flush / 
putEntities}} respectively on writer ? or as [~sjlee0] mentioned 2*2 matrix ?

bq. YARN-3367 already track this. It is painful for the client to wrap 
putEntity() with thread-pool or dispatcher to achieve non-blocking way.
I was under the impression that YARN-3367 is only for invoking REST calls in 
nonblocking way and thus avoiding threads in the clients. Is it also related to 
flush when called only {{putEntities}} and not on {{putEntitiesAsync}}? 
I see currently "async" parameter as part of REST request is ignored now, so i 
thought based on this param we may need to further flush the writer or is your 
thoughts similar to support 2*2 matrix as Sangjin was informing ?

> [Event producers] Implement NM writing container lifecycle events to ATS
> ------------------------------------------------------------------------
>                 Key: YARN-3045
>                 URL: https://issues.apache.org/jira/browse/YARN-3045
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3045-YARN-2928.002.patch, 
> YARN-3045-YARN-2928.003.patch, YARN-3045-YARN-2928.004.patch, 
> YARN-3045-YARN-2928.005.patch, YARN-3045-YARN-2928.006.patch, 
> YARN-3045-YARN-2928.007.patch, YARN-3045.20150420-1.patch
> Per design in YARN-2928, implement NM writing container lifecycle events and 
> container system metrics to ATS.

This message was sent by Atlassian JIRA

Reply via email to