[ 
https://issues.apache.org/jira/browse/YARN-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680331#comment-14680331
 ] 

Junping Du commented on YARN-4035:
----------------------------------

Thanks [~gliptak] for working out a patch and [~rohithsharma] for the comments!
Instead of adding "if (shouldRun)" to start monitorThread in start(), I think 
the right thing to do is set "shouldRun = true" in start(), so JvmPauseMonitor 
could be restarted after stop (or it cannot be restart again).
In addition, given the patch all happens in hadoop-common-project, I think we 
should move the JIRA from YARN to HADOOP.

> Some tests in TestRMAdminService fails with NPE 
> ------------------------------------------------
>
>                 Key: YARN-4035
>                 URL: https://issues.apache.org/jira/browse/YARN-4035
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.8.0
>            Reporter: Rohith Sharma K S
>            Assignee: Gabor Liptak
>         Attachments: YARN-4035.1.patch
>
>
> It is observed that after YARN-4019 some tests are failing in 
> TestRMAdminService with null pointer exceptions in build [build failure 
> |https://builds.apache.org/job/PreCommit-YARN-Build/8792/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt]
> {noformat}
> unning org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService
> Tests run: 19, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 11.541 sec 
> <<< FAILURE! - in 
> org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService
> testModifyLabelsOnNodesWithDistributedConfigurationDisabled(org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService)
>   Time elapsed: 0.132 sec  <<< ERROR!
> java.lang.NullPointerException: null
>       at org.apache.hadoop.util.JvmPauseMonitor.stop(JvmPauseMonitor.java:86)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$RMActiveServices.serviceStop(ResourceManager.java:601)
>       at 
> org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.stopActiveServices(ResourceManager.java:983)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.transitionToStandby(ResourceManager.java:1038)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceStop(ResourceManager.java:1085)
>       at 
> org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
>       at 
> org.apache.hadoop.service.AbstractService.close(AbstractService.java:250)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testModifyLabelsOnNodesWithDistributedConfigurationDisabled(TestRMAdminService.java:824)
> testRemoveClusterNodeLabelsWithDistributedConfigurationEnabled(org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService)
>   Time elapsed: 0.121 sec  <<< ERROR!
> java.lang.NullPointerException: null
>       at org.apache.hadoop.util.JvmPauseMonitor.stop(JvmPauseMonitor.java:86)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$RMActiveServices.serviceStop(ResourceManager.java:601)
>       at 
> org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.stopActiveServices(ResourceManager.java:983)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.transitionToStandby(ResourceManager.java:1038)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceStop(ResourceManager.java:1085)
>       at 
> org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
>       at 
> org.apache.hadoop.service.AbstractService.close(AbstractService.java:250)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testRemoveClusterNodeLabelsWithDistributedConfigurationEnabled(TestRMAdminService.java:867)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to