Junping Du commented on YARN-3045:

bq. Junping Du one more favor can you join us in slack ? faster to communicate 
Sure. I joined before but cannot see anyone online (may be due to different 
timezones). As a typical apache way, discussions on JIRA should be sufficient 
in general.

bq. but wanted to to place the localization events along with ContainerEntity. 
Is that fine ?
Yes. This is fine for now as I claimed above.

bq. Even though these ContainerEvents give details state of container but its 
state machine will be intermediate state (will not be DONE state) when these 
events are being processed (exit code, final state, diagnostic msg etc might 
not be filled in). So in the current patch i have published Containerfinished 
ATS event on APPLICATION_CONTAINER_FINISHED event rather than other container 
events, wanted to check further with you Junping Du, but anyway you only raised 
this topic. i feel it would be better to also capture 
ContainerEvents. thoughts?
APPLICATION_CONTAINER_FINISHED should be enough for now. We can add more 
container events later when we have priority mechanism as my comments above.

bq. Its basically not unrecognized event but its event which is not of our 
interest, so better i can just ignore default case and delete it. ok?
I would slightly prefer to handle them explicitly, including: ignore without 
handling on some events or put some debug/warn messages on unrecognized events. 
The reason is other developers who rename/add new events could forget to handle 
timeline events here, so debug/warn messages could help to identify them.

> [Event producers] Implement NM writing container lifecycle events to ATS
> ------------------------------------------------------------------------
>                 Key: YARN-3045
>                 URL: https://issues.apache.org/jira/browse/YARN-3045
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3045-YARN-2928.002.patch, 
> YARN-3045-YARN-2928.003.patch, YARN-3045-YARN-2928.004.patch, 
> YARN-3045-YARN-2928.005.patch, YARN-3045-YARN-2928.006.patch, 
> YARN-3045-YARN-2928.007.patch, YARN-3045-YARN-2928.008.patch, 
> YARN-3045.20150420-1.patch
> Per design in YARN-2928, implement NM writing container lifecycle events and 
> container system metrics to ATS.

This message was sent by Atlassian JIRA

Reply via email to