[ 
https://issues.apache.org/jira/browse/YARN-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693055#comment-14693055
 ] 

Hadoop QA commented on YARN-3986:
---------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch |   0m  0s | The patch command could not apply 
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12749639/YARN-3986.02.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 1ea1a83 |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/8830/console |


This message was automatically generated.

> getTransferredContainers in AbstractYarnScheduler should be present in 
> YarnScheduler interface instead
> ------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3986
>                 URL: https://issues.apache.org/jira/browse/YARN-3986
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: 2.7.0
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: YARN-3986.01.patch, YARN-3986.02.patch
>
>
> Currently getTransferredContainers is present in {{AbstractYarnScheduler}}.
> *But in ApplicationMasterService, while registering AM, we are calling this 
> method by typecasting it to AbstractYarnScheduler, which is incorrect.*
> This method should be moved to YarnScheduler.
> Because if a custom scheduler is to be added, it will implement 
> YarnScheduler, not AbstractYarnScheduler.
> As ApplicationMasterService is calling getTransferredContainers by 
> typecasting it to AbstractYarnScheduler, it is imposing an indirect 
> dependency on AbstractYarnScheduler for any pluggable custom scheduler.
> We can move the method to YarnScheduler and leave the definition in 
> AbstractYarnScheduler as it is.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to