[
https://issues.apache.org/jira/browse/YARN-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697816#comment-14697816
]
Vrushali C commented on YARN-3904:
----------------------------------
+1 yes we can move ahead.
I am quite curious, how is the accessibility being restricted? The method has
no specifier so that means it is package level visible, no? Also, the
annotations of @private and @VisibleForTesting are only annotations, they don't
really affect the private/public accessibility of the function. Or am I
mistaken?
But that said, let's go ahead with the patch, my question is only for
discussion purpose.
> Refactor timelineservice.storage to add support to online and offline
> aggregation writers
> -----------------------------------------------------------------------------------------
>
> Key: YARN-3904
> URL: https://issues.apache.org/jira/browse/YARN-3904
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Li Lu
> Assignee: Li Lu
> Attachments: YARN-3904-YARN-2928.001.patch,
> YARN-3904-YARN-2928.002.patch, YARN-3904-YARN-2928.003.patch,
> YARN-3904-YARN-2928.004.patch, YARN-3904-YARN-2928.005.patch,
> YARN-3904-YARN-2928.006.patch, YARN-3904-YARN-2928.007.patch,
> YARN-3904-YARN-2928.008.patch, YARN-3904-YARN-2928.009.patch
>
>
> After we finished the design for time-based aggregation, we can adopt our
> existing Phoenix storage into the storage of the aggregated data. In this
> JIRA, I'm proposing to refactor writers to add support to aggregation
> writers. Offline aggregation writers typically has less contextual
> information. We can distinguish these writers by special naming. We can also
> use CollectorContexts to model all contextual information and use it in our
> writer interfaces.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
