[ 
https://issues.apache.org/jira/browse/YARN-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699418#comment-14699418
 ] 

Junping Du commented on YARN-4054:
----------------------------------

Hi [~varun_saxena], thanks for your comments!
bq. We can keep on closing it and reopening it whenever new findbugs warnings 
come.
In general, we don't recommend to keep track of multiple commits within the 
same JIRA. The reason is for release as it will bring extra difficulties to 
track down commits with the same JIRA number.

I saw you already resolve this. My additional comments on fixing minor things 
(findbugs, checkstyle, etc.) on a dev branch is: if it related to trunk, leave 
it to the fix on trunk or it will have unnecessary merge conflict in future; if 
there are many things to fix, we can create a separated JIRA to fix or merge 
the single line of fix to an existing patch sounds like a better way.

> Fix findbugs warnings in YARN-2928 branch
> -----------------------------------------
>
>                 Key: YARN-4054
>                 URL: https://issues.apache.org/jira/browse/YARN-4054
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to