Wangda Tan commented on YARN-4024:

Hi [~zhiguohong],
Thanks for update, some minor comments:
1) I think we can limit the changes of remove cache in the NodesListManager, in 
the handle(..), we can do the flush(..), it will be as same as doing this in 
RMNodeImpl, and don't need expose an extra method, correct?

2) I suggest to rename CachedResolver.flush to something like removeCache, 
flush is more like a file system concept to me.

3) Add tests to see if NodesListManager can handle events correctly if you 
agree with 2).

> YARN RM should avoid unnecessary resolving IP when NMs doing heartbeat
> ----------------------------------------------------------------------
>                 Key: YARN-4024
>                 URL: https://issues.apache.org/jira/browse/YARN-4024
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Wangda Tan
>            Assignee: Hong Zhiguo
>         Attachments: YARN-4024-draft-v2.patch, YARN-4024-draft-v3.patch, 
> YARN-4024-draft.patch
> Currently, YARN RM NodesListManager will resolve IP address every time when 
> node doing heartbeat. When DNS server becomes slow, NM heartbeat will be 
> blocked and cannot make progress.

This message was sent by Atlassian JIRA

Reply via email to