Sunil G commented on YARN-4024:

Hi [~zhiguohong]
Thanks for working on this. Some high level comments.

- I feel {{ExpireChecker}} could extend Timer class and it can be started from 
serviceStart of NodesListManager, and can be cancelled from serviceStop. Pls 
share your opinion.
- Since we use *removeCache*, I think *update* will be better suited as 
- Please add more comments and details about *interface Resolver* and its api. 
I feel the api *resolve* has to be UnStable and Public for now. may be we can 
separate the interface to another file.

> YARN RM should avoid unnecessary resolving IP when NMs doing heartbeat
> ----------------------------------------------------------------------
>                 Key: YARN-4024
>                 URL: https://issues.apache.org/jira/browse/YARN-4024
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Wangda Tan
>            Assignee: Hong Zhiguo
>         Attachments: YARN-4024-draft-v2.patch, YARN-4024-draft-v3.patch, 
> YARN-4024-draft.patch, YARN-4024-v4.patch
> Currently, YARN RM NodesListManager will resolve IP address every time when 
> node doing heartbeat. When DNS server becomes slow, NM heartbeat will be 
> blocked and cannot make progress.

This message was sent by Atlassian JIRA

Reply via email to