[ 
https://issues.apache.org/jira/browse/YARN-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14702996#comment-14702996
 ] 

Sunil G commented on YARN-4014:
-------------------------------

Thanks [~rohithsharma] and [~jianhe] for handling the race condition in 
{{CS#updateApplicationPriority}}.

I feel there is another race condition other than the *null* case of 
*currentAttempt* in SchedulerApplication.
When 2nd or subsequent AM attempt is spawned, we are never setting the old 
attempt as null in *SchedulerApplication*, correct?
Hence there is a chance that we set priority to old attempt while new attempt 
is getting created. As per your new change in {{updateApplicationPriority}}, I 
feel this case is also handled. 
However, I think we may need to make *currentAttempt* also volatile in 
*SchedulerApplication*. pls suggest your thoughts.

{code}
private T currentAttempt;
{code}


> Support user cli interface in for Application Priority
> ------------------------------------------------------
>
>                 Key: YARN-4014
>                 URL: https://issues.apache.org/jira/browse/YARN-4014
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client, resourcemanager
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-4014-V1.patch, 0001-YARN-4014.patch, 
> 0002-YARN-4014.patch, 0003-YARN-4014.patch, 0004-YARN-4014.patch, 
> 0004-YARN-4014.patch
>
>
> Track the changes for user-RM client protocol i.e ApplicationClientProtocol 
> changes and discussions in this jira.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to