Sangjin Lee commented on YARN-3862:

Sorry it took me awhile to get around to looking at this.

As for the timeline filters, strictly speaking these are filters that filter 
based on the column qualifiers, and *not* on the values, right? Or are we 
combining both types of filtering here? IMO, it would be good to limit this to 
filtering of columns only for column qualifiers and not do the values. I think 
those 2 things are conceptually separate, and would cause confusion if they're 

The reason I ask that is the patch has comparison filters 
({{TimelineCompareFilter}}) and operators that are related to comparisons. I'm 
not sure how they relate to the filtering based on the column qualifiers. So 
far we're talking about prefix match for the most part...

On a similar note, how about the filter based on the limit as suggested by 
[~gtCarrera9]? Are we also mixing concepts there? The filters that are 
mentioned here do not select rows but rather pick out *contents* to return 
(i.e. columns or cells), whereas the "limit filter" would be selecting rows. I 
chatted with Joep on this, and I personally feel that it would be useful to 
maintain separation between limiting the contents that are returned (akin to 
contents of SELECT in SQL) and limiting the rows that are selected (akin to the 
WHERE clause in SQL).


> Decide which contents to retrieve and send back in response in TimelineReader
> -----------------------------------------------------------------------------
>                 Key: YARN-3862
>                 URL: https://issues.apache.org/jira/browse/YARN-3862
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
>         Attachments: YARN-3862-YARN-2928.wip.01.patch
> Currently, we will retrieve all the contents of the field if that field is 
> specified in the query API. In case of configs and metrics, this can become a 
> lot of data even though the user doesn't need it. So we need to provide a way 
> to query only a set of configs or metrics.
> As a comma spearated list of configs/metrics to be returned will be quite 
> cumbersome to specify, we have to support either of the following options :
> # Prefix match
> # Regex
> # Group the configs/metrics and query that group.
> We also need a facility to specify a metric time window to return metrics in 
> a that window. This may be useful in plotting graphs 

This message was sent by Atlassian JIRA

Reply via email to