Sangjin Lee commented on YARN-4058:

If I'm not mistaken, the issues with {{ContainerManagerImpl}} exist in the 
trunk (the unused {{ApplicationACLsManager}} issue and the application 
creation). I think we should have a JIRA against the trunk and have it fixed 
there. Thoughts?

As for the other changes, it looks good.

> Miscellaneous issues in NodeManager project
> -------------------------------------------
>                 Key: YARN-4058
>                 URL: https://issues.apache.org/jira/browse/YARN-4058
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Minor
>         Attachments: YARN-4058.YARN-2928.001.patch
> # TestSystemMetricsPublisherForV2.testPublishApplicationMetrics is failing 
> # Unused ApplicationACLsManager in ContainerManagerImpl
> # In ContainerManagerImpl.startContainerInternal ApplicationImpl instance is 
> created and then checked whether it exists in context.getApplications(). 
> everytime ApplicationImpl is created state machine is intialized and 
> TimelineClient is created which is required only if added to the context.

This message was sent by Atlassian JIRA

Reply via email to