[ 
https://issues.apache.org/jira/browse/YARN-4024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707290#comment-14707290
 ] 

Anubhav Dhoot commented on YARN-4024:
-------------------------------------

Hi [~zhiguohong] the fix looks good.
We can avoid adding a sleep to the test if we use Clock instead of System in 
CachedResolver#addToCache and ExpireChecker#run. That way you can use a 
ControlledClock in the test to manipulate time and verify expiry. 
Another minor nit, the assertEquals has an "" as first argument in many places 
in TestNodesListManager. You can remove this argument completely since the 
other overload does the same thing or replace with a proper string if you wish. 

> YARN RM should avoid unnecessary resolving IP when NMs doing heartbeat
> ----------------------------------------------------------------------
>
>                 Key: YARN-4024
>                 URL: https://issues.apache.org/jira/browse/YARN-4024
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Hong Zhiguo
>         Attachments: YARN-4024-draft-v2.patch, YARN-4024-draft-v3.patch, 
> YARN-4024-draft.patch, YARN-4024-v4.patch, YARN-4024-v5.patch, 
> YARN-4024-v6.patch
>
>
> Currently, YARN RM NodesListManager will resolve IP address every time when 
> node doing heartbeat. When DNS server becomes slow, NM heartbeat will be 
> blocked and cannot make progress.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to