Naganarasimha G R commented on YARN-4058:

Thanks [~sjlee0] for the review comments, 
Yes it makes sense to move ApplicationACLsManager related modifications in 
trunk itself as t might involve more changes if we touch constructor. 
bq. This style (having values like null first and then the expression) is a 
carry-over from the C-style defensive coding, and is no longer needed in java.
Ok, Will take care of it in the next patch.
bq. Then the timeline client must be stopped properly as part of lifecycle 
True, we need to handle this too, will take care of it in YARN-3367. For where 
to do it;  As part of initial thoughts i was planning to do it when 
ApplicationImpl(NM class) reaches {{ApplicationState.FINISH_APPLICATION}}.

> Miscellaneous issues in NodeManager project
> -------------------------------------------
>                 Key: YARN-4058
>                 URL: https://issues.apache.org/jira/browse/YARN-4058
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Minor
>         Attachments: YARN-4058.YARN-2928.001.patch
> # TestSystemMetricsPublisherForV2.testPublishApplicationMetrics is failing 
> # Unused ApplicationACLsManager in ContainerManagerImpl
> # In ContainerManagerImpl.startContainerInternal ApplicationImpl instance is 
> created and then checked whether it exists in context.getApplications(). 
> everytime ApplicationImpl is created state machine is intialized and 
> TimelineClient is created which is required only if added to the context.

This message was sent by Atlassian JIRA

Reply via email to