[
https://issues.apache.org/jira/browse/YARN-3528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715754#comment-14715754
]
Varun Saxena commented on YARN-3528:
------------------------------------
# In TestNodeStatusUpdater#createNMConfig, change has been missed. Still see
hardcoded port.
{code}
conf.set(YarnConfiguration.NM_LOCALIZER_ADDRESS,
localhostAddress + ":12346");
{code}
# In TestContainer, port is just used for creating container token. Dont need
to call ServerSocketUtil#getPort.
# Nit : TestNodeManagerShutdown#startContainer, below commented line can be
removed.
{code}
//final int port = ServerSocketUtil.getPort(49156, 10);
{code}
# As you will be changing other things, maybe can change below as well. In
TestNodeManagerShutdown I dont see any need to add a try-catch block here. We
have just replaced 12345 with a passed port.
{code}
- InetSocketAddress containerManagerBindAddress =
- NetUtils.createSocketAddrForHost("127.0.0.1", 12345);
+ InetSocketAddress containerManagerBindAddress = null;
+ try {
+ containerManagerBindAddress =
NetUtils.createSocketAddrForHost("127.0.0.1", port);
+ } catch (Exception e) {
+ throw new RuntimeException("Fail To Get the Port");
+ }
{code}
Other things look fine.
> Tests with 12345 as hard-coded port break jenkins
> -------------------------------------------------
>
> Key: YARN-3528
> URL: https://issues.apache.org/jira/browse/YARN-3528
> Project: Hadoop YARN
> Issue Type: Bug
> Affects Versions: 3.0.0
> Environment: ASF Jenkins
> Reporter: Steve Loughran
> Assignee: Brahma Reddy Battula
> Priority: Blocker
> Labels: test
> Attachments: YARN-3528-002.patch, YARN-3528-003.patch,
> YARN-3528-004.patch, YARN-3528-005.patch, YARN-3528-006.patch, YARN-3528.patch
>
>
> A lot of the YARN tests have hard-coded the port 12345 for their services to
> come up on.
> This makes it impossible to have scheduled or precommit tests to run
> consistently on the ASF jenkins hosts. Instead the tests fail regularly and
> appear to get ignored completely.
> A quick grep of "12345" shows up many places in the test suite where this
> practise has developed.
> * All {{BaseContainerManagerTest}} subclasses
> * {{TestNodeManagerShutdown}}
> * {{TestContainerManager}}
> + others
> This needs to be addressed through portscanning and dynamic port allocation.
> Please can someone do this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
