[ 
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717855#comment-14717855
 ] 

Sangjin Lee commented on YARN-4074:
-----------------------------------

Thanks [~gtCarrera9] for your comments.

{quote}
As a general question, since we're returning our timeline entities as jsons in 
our web service, we need to some sort "rebuild" those entities on the js client 
side, right? If this is the case, we need to provide some js object model to be 
consistent with our TimelineEntity object model? I'm not a front-end expert so 
I'd like to learn the typical practice on this problem.
{quote}
I'm not intimately familiar with that either. I hope someone who's familiar 
could comment?

I'm going to do some refactoring to move away from the if-else branch (yuck). 
There are aspects such as input validation, getting results from HBase, and 
creating the entity objects that can be isolated more clearly. I need to give 
some more thoughts on how to encapsulate that more clearly. This has some 
bearing on the filter-related work that Varun is doing, so I'll try not to 
touch that area in this JIRA.

One thing I forgot to mention is that the current POC patch is a diff against 
the patch for YARN-3901, to be able to isolate the changes for this JIRA. The 
patch for YARN-3901 needs to be reviewed and committed before this can be. 
That's why this patch is missing what's included in the YARN-3901 patch.

> [timeline reader] implement support for querying for flows and flow runs
> ------------------------------------------------------------------------
>
>                 Key: YARN-4074
>                 URL: https://issues.apache.org/jira/browse/YARN-4074
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>         Attachments: YARN-4074-YARN-2928.POC.001.patch, 
> YARN-4074-YARN-2928.POC.002.patch
>
>
> Implement support for querying for flows and flow runs.
> We should be able to query for the most recent N flows, etc.
> This includes changes to the {{TimelineReader}} API if necessary, as well as 
> implementation of the API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to