[ 
https://issues.apache.org/jira/browse/YARN-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720233#comment-14720233
 ] 

Sunil G commented on YARN-3970:
-------------------------------

Thank you [~Naganarasimha]

Yes. We can have the improvement to save an extra save to statestore. And the 
fix for the same looks good.

Few comments

1. updateAppPriority --> updateApplicationPriority. I prefer we can have full 
expanded name here as its a separate class to identify a web app object.
2. {{priority.getPriority() != targetPriority.getPriority()}} We could use 
{{!priority.equals(targetPriority)}}
3. 
{code}
+    AppPriority effectivePriority = new AppPriority(
+        app.getApplicationSubmissionContext().getPriority().getPriority());
{code}
If {{app.getApplicationSubmissionContext().getPriority()}} is NULL, we will get 
n NPE here.


> REST api support for Application Priority
> -----------------------------------------
>
>                 Key: YARN-3970
>                 URL: https://issues.apache.org/jira/browse/YARN-3970
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: webapp
>    Affects Versions: 2.7.1
>            Reporter: Sunil G
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3970.20150828-1.patch
>
>
> REST api support for application priority.
> - get/set priority of an application
> - get default priority of a queue
> - get cluster max priority



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to