Naganarasimha G R commented on YARN-4078:

{{getApplicationAttempt}} is specific to {{AbstractYarnScheduler}}, 
{{getPendingResourceRequestForAttempt}} was introduced as part of YARN-3262, so 
we need to only move {{getPendingResourceRequestForAttempt}} or have a guarded 
check, [~jianhe] can you share your thoughts on this

> Unchecked typecast to AbstractYarnScheduler in AppInfo
> ------------------------------------------------------
>                 Key: YARN-4078
>                 URL: https://issues.apache.org/jira/browse/YARN-4078
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Minor
> Currently getPendingResourceRequestForAttempt is present in 
> {{AbstractYarnScheduler}}.
> *But in AppInfo,  we are calling this method by typecasting it to 
> AbstractYarnScheduler, which is incorrect.*
> Because if a custom scheduler is to be added, it will implement 
> YarnScheduler, not AbstractYarnScheduler.
> This method should be moved to YarnScheduler or it should have a guarded 
> check like in other places (RMAppAttemptBlock.getBlackListedNodes) 

This message was sent by Atlassian JIRA

Reply via email to