[ 
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14725914#comment-14725914
 ] 

Varun Saxena commented on YARN-4074:
------------------------------------

Few comments :

# As TreeSet has been used to sort FlowActivityEntity objects in 
{{HbaseTimelineReaderImpl#getFlowActivityEntities}}, we should either set the 
fields used in {{TimelineEntity#compareTo}} or provide a compareTo method in 
FlowActivityEntity class itself. Otherwise I guess entities need to be sorted 
by date. In which case latter needs to be done.

# In parameterized constructor, {{FlowActivityEntity(String cluster, long time, 
String user, String flowName)}}  better to pass the type into superclass 
constructor ? type can be useful in JSON response ?

# Things like configs have no meaning for flows. So things which have no 
meaning in FlowEntity and FlowActivityEntity should we explicitly set them to 
null ?No need to send them in JSON(even if empty) I guess. 


> [timeline reader] implement support for querying for flows and flow runs
> ------------------------------------------------------------------------
>
>                 Key: YARN-4074
>                 URL: https://issues.apache.org/jira/browse/YARN-4074
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>         Attachments: YARN-4074-YARN-2928.POC.001.patch, 
> YARN-4074-YARN-2928.POC.002.patch
>
>
> Implement support for querying for flows and flow runs.
> We should be able to query for the most recent N flows, etc.
> This includes changes to the {{TimelineReader}} API if necessary, as well as 
> implementation of the API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to