Varun Saxena commented on YARN-4074:

Few more comments.
* {{Scan#setMaxResultSize}} only limits the number of rows fetched from server 
to client in a single call. If more rows are available, they are still fetched 
when {{ResultScanner#next}} is invoked. This leads to more entities than the 
limit being returned. setMaxResultSize works similar to JDBCs' 
So to apply limits in getFlowActivityEntities, we need to have a check for 
limit in for loop as well in conjunction to using setMaxResultSize.

* How do we handle the case of limit being 0 or negative ? In FS based impl, I 
had changed limit to DEFAULT_LIMIT in both the cases. Do the same here ?

> [timeline reader] implement support for querying for flows and flow runs
> ------------------------------------------------------------------------
>                 Key: YARN-4074
>                 URL: https://issues.apache.org/jira/browse/YARN-4074
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>         Attachments: YARN-4074-YARN-2928.POC.001.patch, 
> YARN-4074-YARN-2928.POC.002.patch
> Implement support for querying for flows and flow runs.
> We should be able to query for the most recent N flows, etc.
> This includes changes to the {{TimelineReader}} API if necessary, as well as 
> implementation of the API.

This message was sent by Atlassian JIRA

Reply via email to