[
https://issues.apache.org/jira/browse/YARN-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727440#comment-14727440
]
Varun Saxena commented on YARN-4075:
------------------------------------
Few comments about the patch :
# readResultsWithTimestampsForLongs has been added as stop gap fix to let test
cases in this patch pass. This code will be removed and fixed as part of
YARN-3901. Similarly, compareTo has been added in FlowActivityEntity for the
same reason. This will be handled in YARN-4074. Related issues have been given
as comments in the relevant JIRAs'.
# fields is being parsed in REST but not used currently in YARN-4074.
Continuing with it as it will be used in future.
# userId is also parsed as an optional query param in list of flows query. Not
currently used by backend storage.
# I have not called TimelineReaderWebServices#getEntity/getEntities from
getFlowRun/getFlows directly as I want different messages to be sent back on
exception. some exception based code has been moved to a common method for
reuse though.
# getFlowRun/getFlows is calling getEntity/getEntities in
TimelineReaderManager. If we want different ACLs' to be applied while querying
entities,flows,queues, etc. this may have to change in future.
# TestTimelineReaderWebServicesFlowRun and TestTimelineReaderWebServices will
be combined in future. It has been segregated for the time being(with duplicate
code) because former is using HBase and latter FS based implementation right
now.
> [reader REST API] implement support for querying for flows and flow runs
> ------------------------------------------------------------------------
>
> Key: YARN-4075
> URL: https://issues.apache.org/jira/browse/YARN-4075
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Sangjin Lee
> Assignee: Varun Saxena
> Attachments: YARN-4075-YARN-2928.POC.1.patch
>
>
> We need to be able to query for flows and flow runs via REST.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
