Junping Du commented on YARN-3863:

Copy my comments in YARN-4074 for TimelineReader API:
"Actually, I think we should refactor existing getEntities() API before things 
get worse. It include too many parameters, and most of them are optional. This 
is very un-handy, easily cause bug and very hard to extend in future.
Instead, we should define something like EntityFilter class to include most of 
these optional fields (include time range, topN, info/config/metric 
sub-filters, etc.) which also be extended easily for other filters in future. 

> Enhance filters in TimelineReader
> ---------------------------------
>                 Key: YARN-3863
>                 URL: https://issues.apache.org/jira/browse/YARN-3863
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: YARN-2928
>            Reporter: Varun Saxena
>            Assignee: Varun Saxena
> Currently filters in timeline reader will return an entity only if all the 
> filter conditions hold true i.e. only AND operation is supported. We can 
> support OR operation for the filters as well. Additionally as primary backend 
> implementation is HBase, we can design our filters in a manner, where they 
> closely resemble HBase Filters.

This message was sent by Atlassian JIRA

Reply via email to