Joep Rottinghuis commented on YARN-4102:

Looks good to me. One caveat is in the naming. The behavior you have coded is 
incremental (as suggested in the jira name).
The flag is called force. Force to me sound like drop the existing table and 
write a new one (which may be needed to get the coprocessor to work correctly).
I'm +1 on the patch provided that you modify the flag name to i for 
incremental, or better yet "s" for skip existing tables.

> Add an "incremental" mode for timeline schema creator
> -----------------------------------------------------
>                 Key: YARN-4102
>                 URL: https://issues.apache.org/jira/browse/YARN-4102
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Li Lu
>            Assignee: Li Lu
>         Attachments: YARN-4102-YARN-2928.001.patch
> When debugging timeline POCs, we may need to create hbase tables that are 
> added in some ongoing patches. Right now, our schema creator will exit when 
> it hits one existing table. While this is a correct behavior with end users, 
> this introduces much trouble in debugging POCs: every time we have to disable 
> all existing tables, drop them, run the schema creator to generate all 
> tables, and regenerate all test data. 
> Maybe we'd like to add an "incremental" mode so that the creator will only 
> create non-existing tables? This is pretty handy in deploying our POCs. Of 
> course, consistency has to be kept in mind across tables. 

This message was sent by Atlassian JIRA

Reply via email to