[
https://issues.apache.org/jira/browse/YARN-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14727928#comment-14727928
]
Varun Saxena commented on YARN-3816:
------------------------------------
[~djp],
bq. Findbugs warning doesn't hint anything.
Actually there is a problem with Hadoop QA's HTML report for Findbugs. We
always see 0 in HTML reports even if there are findbugs warnings. I had raised
an issue for this as well.
When QA reports -1 for findbugs, there are warnings. We have to run findbugs
manually (by using {{mvn findbugs:findbugs}} or findbugs command) to find it.
Below are the 5 warnings reported above.
{noformat}
<file
classname='org.apache.hadoop.yarn.api.records.timelineservice.TimelineMetricCalculator'>
<BugInstance type='DM_NUMBER_CTOR' priority='Normal' category='PERFORMANCE'
message='org.apache.hadoop.yarn.api.records.timelineservice.TimelineMetricCalculator.delta(Number,
Number, Long) invokes inefficient new Long(long) constructor; use
Long.valueOf(long) instead' lineNumber='127'/>
<BugInstance type='DM_NUMBER_CTOR' priority='Normal' category='PERFORMANCE'
message='org.apache.hadoop.yarn.api.records.timelineservice.TimelineMetricCalculator.sub(Number,
Number) invokes inefficient new Integer(int) constructor; use
Integer.valueOf(int) instead' lineNumber='49'/>
<BugInstance type='DM_NUMBER_CTOR' priority='Normal' category='PERFORMANCE'
message='org.apache.hadoop.yarn.api.records.timelineservice.TimelineMetricCalculator.sub(Number,
Number) invokes inefficient new Long(long) constructor; use Long.valueOf(long)
instead' lineNumber='47'/>
<BugInstance type='DM_NUMBER_CTOR' priority='Normal' category='PERFORMANCE'
message='org.apache.hadoop.yarn.api.records.timelineservice.TimelineMetricCalculator.sum(Number,
Number) invokes inefficient new Integer(int) constructor; use
Integer.valueOf(int) instead' lineNumber='88'/>
<BugInstance type='DM_NUMBER_CTOR' priority='Normal' category='PERFORMANCE'
message='org.apache.hadoop.yarn.api.records.timelineservice.TimelineMetricCalculator.sum(Number,
Number) invokes inefficient new Long(long) constructor; use Long.valueOf(long)
instead' lineNumber='86'/>
</file>
{noformat}
> [Aggregation] App-level Aggregation for YARN system metrics
> -----------------------------------------------------------
>
> Key: YARN-3816
> URL: https://issues.apache.org/jira/browse/YARN-3816
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Junping Du
> Assignee: Junping Du
> Attachments: Application Level Aggregation of Timeline Data.pdf,
> YARN-3816-YARN-2928-v1.patch, YARN-3816-YARN-2928-v2.1.patch,
> YARN-3816-YARN-2928-v2.2.patch, YARN-3816-YARN-2928-v2.patch,
> YARN-3816-poc-v1.patch, YARN-3816-poc-v2.patch
>
>
> We need application level aggregation of Timeline data:
> - To present end user aggregated states for each application, include:
> resource (CPU, Memory) consumption across all containers, number of
> containers launched/completed/failed, etc. We need this for apps while they
> are running as well as when they are done.
> - Also, framework specific metrics, e.g. HDFS_BYTES_READ, should be
> aggregated to show details of states in framework level.
> - Other level (Flow/User/Queue) aggregation can be more efficient to be based
> on Application-level aggregations rather than raw entity-level data as much
> less raws need to scan (with filter out non-aggregated entities, like:
> events, configurations, etc.).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
