Sunil G commented on YARN-4044:

Thank You [~Naganarasimha] for sharing the comments.

bq.ApplicationHistoryManagerOnTimelineStore.convertToApplicationReport needs to 
capture the event ApplicationMetricsConstants.UPDATED_EVENT_TYPE 
I feel this is not needed. We are already not handling 
{{ACLS_UPDATED_EVENT_TYPE}} also. I think we use different handling in 
{{convertToApplicationReport}} for CREATED_EVENT_TYPE and FINISHED_EVENT_TYPE 
to record appStarted time and appFinished time (plus few other finished details)
I used {{entityInfo}} to store Queue and Priority details. Hence the first part 
of code in {{convertToApplicationReport}} covers reading that details and will 
fed to {{ApplicationReportExt}} object.  Please share your opinion.

bq.we need to check return the report with the information present in latest 
One doubt here. We already are using {{EnumSet.allOf(Field.class)}} in 
{{ApplicationHistoryManagerOnTimelineStore.getApplication}} and hence it has 
{{LAST_EVENT_ONLY}} field. So we will read the last saved entity. Please help 
to correct me if I am wrong.

> Running applications information changes such as movequeue is not published 
> to TimeLine server
> ----------------------------------------------------------------------------------------------
>                 Key: YARN-4044
>                 URL: https://issues.apache.org/jira/browse/YARN-4044
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager, timelineserver
>    Affects Versions: 2.7.0
>            Reporter: Sunil G
>            Assignee: Sunil G
>            Priority: Critical
>         Attachments: 0001-YARN-4044.patch, 0002-YARN-4044.patch
> SystemMetricsPublisher need to expose an appUpdated api to update any change 
> for a running application.
> Events can be 
>       - change of queue for a running application.
>         - change of application priority for a running application.
> This ticket intends to handle both RM and timeline side changes. 

This message was sent by Atlassian JIRA

Reply via email to