Wangda Tan commented on YARN-4081:

Thanks for update, [~vvasudev].

Few comments,
Regarding to Resources:

For NONE/UNBOUNDED, maybe we don't need to initialize a real map for it. For 
example, when query resource information of NONE, it should return 
ResourceInformation.value=0 for all given resource type. And the returned 
getResources() map is not a real map too, it should return a fake map that 
always returns ResourceInformation for any given resource type.

Is it possible to merge implementation of NONE/UNBOUNDED?

And I found ResourceRequestInfo changes aren't related to this patch, should 
they be better moved to the other following patch? (such as support multiple 
resource types in REST API).

> Add support for multiple resource types in the Resource class
> -------------------------------------------------------------
>                 Key: YARN-4081
>                 URL: https://issues.apache.org/jira/browse/YARN-4081
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: YARN-4081-YARN-3926.001.patch, 
> YARN-4081-YARN-3926.002.patch, YARN-4081-YARN-3926.003.patch, 
> YARN-4081-YARN-3926.004.patch, YARN-4081-YARN-3926.005.patch
> For adding support for multiple resource types, we need to add support for 
> this in the Resource class.

This message was sent by Atlassian JIRA

Reply via email to