Junping Du commented on YARN-4087:

Thanks [~jianhe] for updating the patch and [~xgong] for the review! Patch LGTM 
mostly, except one NIT here:
+      LOG.warn("Fail RM now due to state-store error!");
I think we should use error or even fatal for this message.

> Followup fixes after YARN-2019 regarding RM behavior when state-store error 
> occurs
> ----------------------------------------------------------------------------------
>                 Key: YARN-4087
>                 URL: https://issues.apache.org/jira/browse/YARN-4087
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-4087.1.patch, YARN-4087.2.patch, YARN-4087.3.patch, 
> YARN-4087.5.patch, YARN-4087.6.patch
> Several fixes:
> 1. Set YARN_FAIL_FAST to be false by default, since this makes more sense in 
> production environment.
> 2. If HA is enabled and if there's any state-store error, after the retry 
> operation failed, we always transition RM to standby state.  Otherwise, we 
> may see two active RMs running. YARN-4107 is one example.

This message was sent by Atlassian JIRA

Reply via email to