[ 
https://issues.apache.org/jira/browse/YARN-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Varun Vasudev updated YARN-4081:
--------------------------------
    Attachment: YARN-4081-YARN-3926.006.patch

{quote}
1) 
For NONE/UNBOUNDED, maybe we don't need to initialize a real map for it. For 
example, when query resource information of NONE, it should return 
ResourceInformation.value=0 for all given resource type. And the returned 
getResources() map is not a real map too, it should return a fake map that 
always returns ResourceInformation for any given resource type.
{quote}

For now, I've left it as it is. Once we have the units stuff figured out, we 
can re-visit this. The specific case we need to figure out is what to return 
for the getResources() call.

{quote}
2)
Is it possible to merge implementation of NONE/UNBOUNDED?
{quote}

Fixed.

{quote}
And I found ResourceRequestInfo changes aren't related to this patch, should 
they be better moved to the other following patch? (such as support multiple 
resource types in REST API).
{quote}
The problem is that without the ResourceRequestInfo class, the RM web services 
tests fail. This is due to some JAXB JSON generation but I wasn't able to 
figure out the root cause.

I've also renamed the ResourceMapEntry proto to ResourceInformationProto in the 
latest patch to get rid of any confusion.

> Add support for multiple resource types in the Resource class
> -------------------------------------------------------------
>
>                 Key: YARN-4081
>                 URL: https://issues.apache.org/jira/browse/YARN-4081
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Varun Vasudev
>            Assignee: Varun Vasudev
>         Attachments: YARN-4081-YARN-3926.001.patch, 
> YARN-4081-YARN-3926.002.patch, YARN-4081-YARN-3926.003.patch, 
> YARN-4081-YARN-3926.004.patch, YARN-4081-YARN-3926.005.patch, 
> YARN-4081-YARN-3926.006.patch
>
>
> For adding support for multiple resource types, we need to add support for 
> this in the Resource class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to