Wangda Tan commented on YARN-3717:

Hi [~Naganarasimha], thanks for working on this JIRA, took a look at the patch, 
few comments:
- In ApplicationCLI/AppInfo, it converts application's nodeLabelExpression to 
"" when it's "null". I think it's better to keep the "null", we can show it 
like "<not set>", otherwise it will cause confusion if the am's 
nodeLabelExpression = "", but it inherits queue's defaultNodeLabelExpression.
- And we'd better show "DEFAULT_PARTITION" when an app's label="", to make it 
consistent with queue's page.
- I'm not very familiar with ATS-related changes. [~gtCarrera9], could you take 
a look at it?

> Improve RM node labels web UI
> -----------------------------
>                 Key: YARN-3717
>                 URL: https://issues.apache.org/jira/browse/YARN-3717
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>         Attachments: 3717_cluster_test_snapshots.zip, RMLogsForHungJob.log, 
> YARN-3717.20150822-1.patch, YARN-3717.20150824-1.patch, 
> YARN-3717.20150825-1.patch, YARN-3717.20150826-1.patch
> 1> Add the default-node-Label expression for each queue in scheduler page.
> 2> In Application/Appattempt page  show the app configured node label 
> expression for AM and Job

This message was sent by Atlassian JIRA

Reply via email to