[ 
https://issues.apache.org/jira/browse/YARN-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738728#comment-14738728
 ] 

Junping Du commented on YARN-313:
---------------------------------

Thanks [~elgoiri] for updating the patch! Current patch LGTM in overall but 
just a few NITs:
1. After think again, we should mark new added API as Evolving instead of 
Stable, like: RefreshResourcesRequest, RefreshResourcesResponse.
2. Tests for PB implementation of RefreshResourcesRequest and 
RefreshResourcesResponse needed to be added to TestPBImplRecords.java like 
other protocol records.
3. Fix checkstyle issues reported by Jenkins (ignore the first one as we can do 
nothing on this).

> Add Admin API for supporting node resource configuration in command line
> ------------------------------------------------------------------------
>
>                 Key: YARN-313
>                 URL: https://issues.apache.org/jira/browse/YARN-313
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Junping Du
>            Assignee: Inigo Goiri
>            Priority: Critical
>         Attachments: YARN-313-sample.patch, YARN-313-v1.patch, 
> YARN-313-v2.patch, YARN-313-v3.patch, YARN-313-v4.patch, YARN-313-v5.patch, 
> YARN-313-v6.patch, YARN-313-v7.patch, YARN-313-v8.patch, YARN-313-v9.patch
>
>
> We should provide some admin interface, e.g. "yarn rmadmin -refreshResources" 
> to support changes of node's resource specified in a config file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to