MENG DING commented on YARN-1644:

Hi, [~leftnoteasy]

There are 7 findbugs warnings, but they already existed before the patch. This 
patch does not generate new findbugs warnings. 

I took a quick look at some of the warnings:

* The warnings in {{NodeStatusPBImpl}} are most likely because 
 are not synchronized
* The warnings in {{WebServices}} are probably because of potential NPE.

I will open a ticket to fix them.

> RM-NM protocol changes and NodeStatusUpdater implementation to support 
> container resizing
> -----------------------------------------------------------------------------------------
>                 Key: YARN-1644
>                 URL: https://issues.apache.org/jira/browse/YARN-1644
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Wangda Tan
>            Assignee: MENG DING
>             Fix For: YARN-1197
>         Attachments: YARN-1644-YARN-1197.4.patch, 
> YARN-1644-YARN-1197.5.patch, YARN-1644-YARN-1197.6.patch, YARN-1644.1.patch, 
> YARN-1644.2.patch, YARN-1644.3.patch, yarn-1644.1.patch

This message was sent by Atlassian JIRA

Reply via email to