nijel commented on YARN-4111:

Thanks [~sunilg] for the comments
bq. RMAppKilledAttemptEvent is used for both RMApp and RMAppAttempt. Name is 
slightly confusing. I think we can use this only for RMApp.
This is the same as failed and finished event. So i think this is ok.

bq. Also in RMAppAttempt, RMAppFailedAttemptEvent is changed to 
RMAppKilledAttemptEvent. Could we generalize RMAppFailedAttemptEvent for both 
Failed and Killed, and it can also take diagnostics.
before this fix failed event is raised with KILLED as state. SInce now the new 
event for kill is available it is changed.

> Killed application diagnostics message should be set rather having static 
> mesage
> --------------------------------------------------------------------------------
>                 Key: YARN-4111
>                 URL: https://issues.apache.org/jira/browse/YARN-4111
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>            Reporter: Rohith Sharma K S
>            Assignee: nijel
>         Attachments: YARN-4111_1.patch, YARN-4111_2.patch
> Application can be killed either by *user via ClientRMService* OR *from 
> scheduler*. Currently diagnostic message is set statically i.e {{Application 
> killed by user.}} neverthless of application killed by scheduler. This brings 
> the confusion to the user after application is Killed that he did not kill 
> application at all but diagnostic message depicts that 'application is killed 
> by user'.
> It would be useful if the diagnostic message are different for each cause of 

This message was sent by Atlassian JIRA

Reply via email to